after-analyze-file

C++ After-Analyze-File (v2)

Post-hook invoked after code-analysis:analyze-file completes in a C/C++ project. In v2, static tools (clang-tidy, cppcheck, iwyu) have already produced their findings — this skill adds only qualitative C++ judgments on top.

Scope (what to add to the mirror)

Append a ## C++ Qualitative Audit section with these subsections:

1. RAII posture — Does the class manage resources with RAII? Any raw new/delete pairs?
2. Exception safety — Strong/basic/no-throw guarantees where relevant. Any exception-unsafe patterns (cleanup after potentially-throwing ops)?
3. Thread safety — Shared mutable state without synchronization? Lock hierarchies? Atomic usage appropriateness?
4. Resource lifetime — Ownership models (unique/shared/borrowed). Dangling-reference risks. Iterator invalidation.
5. Header hygiene (declaration files only) — Unnecessary includes-in-header (iwyu already covers this; only add commentary, don't re-list).
6. Move / copy semantics (implementation files only) — Unnecessary copies, rule-of-5 consistency.

Rules

• Never repeat static tool findings. If clang-tidy flagged a null-deref, don't flag it again — reference it ("per clang-tidy CA-4, the null-deref at line 73 reinforces the broader ownership issue").
• Use graph_context.callers/callees to judge whether a pattern's risk is theoretical or real-world-reached.
• Length: one paragraph per subsection; empty subsections omitted.

Output

Append to the existing mirror file (do not overwrite other sections).