code-review

Code Review

Runs after code generation and before final completion. Performs a structured review of all changed files, delegates framework-specific checks to the active framework module, and enforces LSP cleanliness.

Review Flow

Execute the following steps in order:

Step 1 — Identify Changed Files

Collect all files created or modified during the current session. Group by extension and directory to establish scope.

Step 2 — Detect Component Type

For each file, invoke the component-detection skill to classify the file as one of: page, component, hook, layout, utility, style. The component type drives which framework sub-skills are invoked and which guideline sections apply.

Step 3 — Load Resolved Guidelines

Invoke config-resolver to obtain the final merged guidelines for the current session. Guidelines are resolved from three layers (plugin defaults < team custom < per-invocation). The resolved output is a map of ## Section headings to their content.

Step 4 — Check Code Against Guidelines

For each changed file, verify it conforms to every applicable section in the resolved guidelines. A guideline violation is a blocker.

• Reference the specific guideline section and heading in the output.
• Do not invent rules not present in the resolved guidelines.

Step 5 — Delegate to Framework: Component Patterns

Invoke the active framework module's <fw>-components skill (e.g., react-components, angular-components, vue-components) for all files classified as page, component, layout, or hook. The framework skill checks framework-specific patterns (composition, lifecycle, props/inputs/outputs, state management integration).

Step 6 — Delegate to Framework: Styling Consistency

Invoke the active framework module's <fw>-styling skill for all files that contain styling (CSS-in-JS, Tailwind classes, CSS Modules, SCSS). The styling skill verifies consistency with the resolved styling strategy and design token usage.

Step 7 — LSP Diagnostics

Run LSP.getDiagnostics on all changed files.

• Zero errors are required. Any LSP error is a blocker.
• Warnings are surfaced as warnings in the review output.
• Do not proceed to Step 8 if LSP errors are present; report and halt.

Step 8 — Import Verification

Run LSP.getReferences on all imports within changed files to verify that every import resolves to an existing module or export. Broken imports are blockers.

Step 9 — Accessibility Review (Always)

Invoke accessibility-review. This step always runs regardless of component type or configuration. Blockers reported by accessibility-review are blockers for code-review.

Step 10 — i18n Review (Conditional)

If i18n.enabled is true in the resolved config, invoke i18n-review. Blockers reported by i18n-review are blockers for code-review. If i18n.enabled is false or absent, skip this step.

Output Format

Produce a structured review report grouped by severity, then by file.

## Code Review Report

### Blockers (must fix)

[BLOCKER] Guidelines — Violates "## Naming Conventions": component file uses kebab-case, must be PascalCase
  File: src/components/user-profile.tsx, line 1
  Guideline: ## Naming Conventions
  Fix: Rename file to UserProfile.tsx

[BLOCKER] LSP — Type error: Argument of type 'string' is not assignable to parameter of type 'number'
  File: src/components/UserProfile.tsx, line 28
  Fix: Pass a numeric ID or update the function signature

[BLOCKER] Accessibility — Missing <main> landmark (see accessibility-review output)

### Warnings

[WARNING] Framework Patterns — useEffect dependency array missing 'userId' (react-components)
  File: src/components/UserProfile.tsx, line 45
  Fix: Add userId to the dependency array

[WARNING] Styling — Hardcoded color value; prefer design token (react-styling)
  File: src/components/UserProfile.tsx, line 12

### Suggestions / Nits

[NIT] Guidelines — Consider extracting inline handler to named function for readability
  File: src/components/UserProfile.tsx, line 67

The review is complete only when zero blockers remain. If blockers exist, report them and request fixes before marking the task done.