postgres-code-review

PostgreSQL Code Review

Quick Reference

Issue Type	Reference
Missing indexes, wrong index type, query performance	references/indexes.md
JSONB queries, operators, GIN indexes	references/jsonb.md
Connection leaks, pool configuration, timeouts	references/connections.md
Isolation levels, deadlocks, advisory locks	references/transactions.md

Review Checklist

• WHERE/JOIN columns have appropriate indexes
• Composite indexes match query patterns (column order matters)
• JSONB columns use GIN indexes when queried
• Using proper JSONB operators (->, ->>, @>, ?)
• Connection pool configured with appropriate limits
• Connections properly released (context managers, try/finally)
• Appropriate transaction isolation level for use case
• No long-running transactions holding locks
• Advisory locks used for application-level coordination
• Queries use parameterized statements (no SQL injection)

When to Load References

• Reviewing SELECT queries with WHERE/JOIN → indexes.md
• Reviewing JSONB columns or JSON operations → jsonb.md
• Reviewing database connection code → connections.md
• Reviewing BEGIN/COMMIT or concurrent updates → transactions.md

Review Questions

1. Will this query use an index or perform a sequential scan?
2. Are JSONB operations using appropriate operators and indexes?
3. Are database connections properly managed and released?
4. Is the transaction isolation level appropriate for this operation?
5. Could this cause deadlocks or long-running locks?