caa-pr-review-and-fix-skill

PR Review And Fix

Overview

Iterative review-and-fix: six-phase review (P1, Phase 4 security scan is MANDATORY) then fix+test+commit (P2), repeating up to 25 passes.

Prerequisites

gh authenticated, PR on GitHub, reports/code-auditor/ exists, ${CLAUDE_PLUGIN_ROOT} set, scripts/caa-merge-reports.py

Instructions

1. Initialize PASS_NUMBER=1, MAX_PASSES=25. Read critical-rules.md first.
2. Run PROCEDURE 1 (six-phase review): see procedure-1-review.md.
3. If zero issues found, write final report and exit with APPROVE.
4. If PASS_NUMBER > MAX_PASSES, write escalation report and exit.
5. Run PROCEDURE 2 (fix cycle): see procedure-2-fix.md.
6. Increment PASS_NUMBER, go to step 2.

Output

• Output Format:
  • Deliverables Table, Key Outputs for the User

Error Handling

• Error Handling:
  • Error Recovery by Phase
• Agent Recovery:
  • Failure Modes & Detection, Step 1: Detect the Loss, Step 2: Verify the Loss, Step 3: Clean Up Partial Artifacts
  • Step 4: Re-Spawn the Task, Step 5: Record the Failure, Special Cases, Lost during context compaction
  • Agent wrote report with wrong pass number (version/cache collision), Agent Recovery Checklist
  • Multiple correctness agents for the same domain (domain label collision), Test runner left no report but tests actually ran

Checklist

Copy this checklist and track your progress:

• All passes completed, zero issues
• Final report in reports/code-auditor/

Examples

Input: "review and fix PR 206"
Output: Pass 1: 8 issues fixed. Pass 2: 2 regressions. Pass 3: 0 issues → APPROVE.

Resources

• Procedure 1: Code Review:
  • Pre-Pass Cleanup (MANDATORY), Agent Manifest, Prerequisites, Phase 1: Code Correctness Swarm
  • Phase 2: Claim Verification, Phase 3: Skeptical Review, Phase 4: Security Review
  • Phase 5: Merge Reports + Deduplicate, Phase 6: Present Results, Procedure 1 Checklist
• Procedure 2: Code Fix:
  • Agent Selection (Dynamic), Fix Protocol, Linting Step (Docker Required)
  • Commit After Fixes, Procedure 2 Output, Procedure 2 Checklist
• Pass Counter:
  • Initialization, Run ID Generation, Pass Increment and Limit
• Loop Termination:
  • Termination Logic, Final Report Format
• Report Naming:
  • Canonical Pattern, Main-Root Resolution (Worktree-Safe), Timestamp Format
  • PIPELINE_TS vs Per-Agent TS, Filename Table, Agent-Prefixed Finding IDs, Pre-Pass Cleanup
• Critical Rules:
  • Rule 1: Never Skip Phases, Rule 2: Phase Order Matters, Rule 3: UUID-Named Files
  • Rule 4: Two-Stage Merge, Rule 5: Dedup Agent Determines Verdict, Rule 6: Fix All Severities
  • Rule 7: Commit After Each Fix Pass, Rule 8: Maximum 25 Passes, Rule 9: Agent-Prefixed Finding IDs
  • Rule 10: UUID-Based Report Filenames, Rule 11: Same Line Different Bugs
  • Rule 12: Merge Script Verifies Before Deleting, Rule 13: Linting Is Conditional on Docker
  • Rule 14: Lint-Fix Loop Is Separate
• Model Selection:
  • Rules
• Worktree Mode:
  • How It Works, Prerequisites for Worktree Mode, When NOT to Use Worktrees
• Rationale:
  • The Incident, Four Complementary Review Perspectives
• Lessons Learned:
  • Review Architecture Lessons, Fix Cycle Lessons, Pipeline Robustness Lessons, Lessons Learned Review Checklist
• Examples:
  • Full Review-and-Fix Pipeline