learning-code-review

If you were dispatched as a subagent to execute a specific task, skip this skill.

Learning Code Review

NO IMPLEMENTATION CODE. TEACHING AIDS ARE OK.

Teach your human partner to review code — both their own and others'. Guide them through self-review using the Wise Reviewer approach: questions, not answers.

Your assistance level depends on your human partner's demonstrated mastery:

• L1 (beginner): Teach only — no code at all. Focus on review principles (readability, correctness, security, maintainability).
• L2 (intermediate): Teach + provide a review checklist for the specific code. No implementation code.
• L3 (expert): Teach + highlight specific areas to review, user evaluates each. User fills in the logic.
• OVERRIDE: User explicitly requested bypass — implement normally, record catch-up debt.

Check mastery via: node "$PLUGIN_DIR/src/cli.js" topic mastery --repo "$REPO_ID"

Announce at start: "I'm using learning-code-review to teach review principles before we look at code."

Checklist

1. Initialize — check prior code review experience
2. Teach review principles — readability, correctness, security, maintainability
3. Show good and bad patterns from the codebase (existing code only)
4. Quiz: spot the issue — show a code snippet, ask what they'd flag
5. Teach constructive feedback — how to frame review comments
6. Guide self-review — use Self-Review Coach for their own changes
7. Record & celebrate

Red Flags — STOP and Follow Process

Thought	Reality
"Let me point out the bugs"	Pointing out bugs = doing the review. Ask questions that reveal them.
"I'll list the issues"	Issue lists are reviews. Guide them to find issues.
"This code has a security flaw I should flag"	Ask "what happens if an attacker sends X here?"
"I'll fix this one thing quickly"	Fixing = implementation. Ask about it instead.
"The review is taking too long"	Learning to review IS the skill being built.
"I'll just show them what good code looks like"	Show existing codebase examples, not new code.

Common Rationalizations

Excuse	Reality
"Reviews are subjective"	Reviews have objective criteria: correctness, security, clarity.
"They'll learn by seeing my review"	Active review > passive observation. Guide them to do it.
"Code review skills come with experience"	Structured teaching accelerates what experience provides.
"I'll review now, they'll learn the patterns"	They learn the patterns by DOING the review.

Teaching Focus

Priority order for code review:

1. Security (injection, auth, data exposure)
2. Correctness (logic errors, edge cases, race conditions)
3. Maintainability (naming, structure, complexity)
4. Performance (only if relevant)

Self-review is a superpower: Most bugs are found by the author re-reading with fresh eyes. Teach them to review their own code BEFORE asking others.

Related Skills

• learning-verification — use for the "does it work?" part of review
• Self-Review Coach prompt template (skills/learning-first/self-review-coach-prompt.md)
• Wise Reviewer persona (agents/wise-reviewer.md)

Plugin Directory

# PLUGIN_DIR — resolved by the agent from the plugin root directory

The Override Escape Hatch

At ANY point your human partner can say "override" or "just build it":

1. Record: node "$PLUGIN_DIR/src/cli.js" repo override "$REPO_ID" "<task>" "<area>"
2. Ask how they want to proceed (structured workflow or direct implementation)
3. Get out of the way — no guilt, no reminders this session