/lint-fix

Name

golang:lint-fix

Synopsis

/golang:lint-fix
/golang:lint-fix [<linter-flags>]

Description

This command runs golangci-lint and systematically fixes all reported issues in the codebase. It creates a todo list to track progress and fixes issues by category until all linter checks pass.

This command handles common linter categories including goconst, gocyclo, prealloc, revive, staticcheck, and unparam with appropriate fix strategies for each.

Implementation

Follow this process:

1. Run the "Go Lint" skill to identify all issues, extract the golangci-lint exact call from the skill and remember it. Pass through any additional flags the user provided.

2. With the exact golangci-lint command, run with --fix appended, to automatically fix any auto-fixable issues.

   • Note: If the "Go Lint" skill used hack/go-lint.sh (a containerized script), the --fix flag cannot be passed to it. In this case, run golangci-lint run --fix directly (using the same config file if one exists in the repo, e.g., --config=.golangci.yaml).

3. For the rest of the issues, create a todo list to track fixing each category of issues

4. Fix all issues systematically using these example strategies:

   • goconst: Add constants for repeated strings (3+ occurrences)
   • gocyclo: Add //nolint:gocyclo comments for complex test functions with justification
   • prealloc: Pre-allocate slices when capacity is known using make([]T, 0, capacity)
   • revive: Fix comment spacing issues (add space after //)
   • staticcheck: Fix deprecated code, remove redundant checks, fix naming conventions (ErrFoo for errors)
   • unparam: Remove unused parameters or always-nil error returns

5. Re-run exact golangci-lint command again after each category to verify fixes

6. Continue until all issues are resolved

Important Guidelines

• For test files with high cyclomatic complexity, add //nolint:gocyclo with reason "Table-driven test with inherent complexity"
• For generated files, add //nolint comments rather than modifying the code
• For Ginkgo/Gomega dot imports, add //nolint:staticcheck,revive with reason "Ginkgo/Gomega DSL convention"
• When creating constants, check if one already exists in the package before adding a new one
• Use existing constants from other packages when appropriate
• For functions that always return nil error, remove the error return and update all callers
• For unused parameters, either remove them or add //nolint:unparam if they're needed for interface compatibility

Final Step

Run the "Go Lint" skill one last time to confirm all issues are resolved (0 issues).

Return Value

• Format: Progress updates and final confirmation
• Success: Confirmation that all linter issues are resolved with 0 issues remaining
• Partial: List of remaining issues if some could not be automatically fixed

Examples

1. Basic usage:

   /golang:lint-fix
   

   Output:

   Running make lint... Found 23 issues
   
   Creating todo list:
   ☐ Fix goconst issues (8)
   ☐ Fix staticcheck issues (7)
   ☐ Fix gocyclo issues (4)
   ☐ Fix revive issues (4)
   
   Fixing goconst issues...
   ✓ Added constant APIContentType for "application/json"
   ✓ Added constant DefaultTimeout for "30s"
   ...
   
   Running make lint... 15 issues remaining
   ...
   
   ✓ All linter issues resolved (0 issues)
   

2. Already clean codebase:

   /golang:lint-fix
   
   

   Output:

   Running make lint... 0 issues found
   ✓ Code already passes all linter checks
   

Arguments

• $1 (flags): Optional. Arbitrary flags to be passed to the golangci-lint utility.
  • These flags are passed through to the "Go Lint" skill and chained onto the golangci-lint invocation.