Repository Pattern Check

IMPORTANT: When this command is invoked, you MUST actually SCAN the codebase and REPORT findings. Do NOT just describe what to check.

Step 1: Find Layer Files

Use Glob to find files in each layer:

Routers:      {backend}/api/routers/*.py
Services:     {backend}/api/services/*_service.py
Repositories: {backend}/api/repositories/*_repository.py

Step 2: Check Each Layer for Violations

2.1 Router Violations

Routers should ONLY:

• Accept HTTP requests
• Validate input
• Call services
• Return responses

❌ VIOLATIONS to find:

• Direct repository imports: from api.repositories.* import *Repository
• Direct model imports used for queries
• Raw SQL or session.execute()

2.2 Service Violations

Services should:

• Contain business logic
• Call repositories for data access
• NOT perform raw database operations

❌ VIOLATIONS to find:

• session.execute(text(...) - Raw SQL
• session.query(...) - Direct query
• select(Model).where(...) without using repository

2.3 Repository Violations

Repositories should:

• Handle ONLY data access
• Use flush() not commit()
• NOT contain business logic

❌ VIOLATIONS to find:

• session.commit() - Should use flush()
• Business logic (password hashing, validation, notifications)
• HTTP exceptions (HTTPException, status.HTTP_*)

Step 3: Output Report

FORMAT YOUR OUTPUT EXACTLY LIKE THIS:

╔══════════════════════════════════════════════════════════════╗
║            REPOSITORY PATTERN COMPLIANCE REPORT              ║
╚══════════════════════════════════════════════════════════════╝

📋 LAYER ANALYSIS
────────────────────────

🔷 ROUTERS
✅ user_router.py - Clean (delegates to services)
✅ role_router.py - Clean
❌ order_router.py - VIOLATION: Direct repository call

🔷 SERVICES
✅ user_service.py - Clean (uses repositories)
❌ report_service.py - VIOLATION: Raw SQL query

🔷 REPOSITORIES
✅ user_repository.py - Clean (uses flush)
❌ order_repository.py - VIOLATION: Calls commit()

📊 VIOLATIONS DETAIL
────────────────────────

order_router.py:
  Line 45: from api.repositories.order_repository import OrderRepository
  Line 67: repo = OrderRepository()  ❌ Router should not use repository directly

report_service.py:
  Line 89: result = await session.execute(text("SELECT ..."))  ❌ Raw SQL in service

order_repository.py:
  Line 34: await session.commit()  ❌ Should use flush()

📊 SUMMARY
────────────────────────
Routers clean: 5/6
Services clean: 4/5
Repositories clean: 5/6
Total violations: 3

🔧 REQUIRED FIXES
────────────────────────
1. order_router.py: Move repository call to OrderService
2. report_service.py: Create ReportRepository for raw queries
3. order_repository.py: Replace commit() with flush()

Step 4: Offer to Fix (If Issues Found)

If violations are found, ask: "Would you like me to fix the layer separation violations?"

If user agrees:

Fix Router Violations:

Move repository calls to services:

# Before (router)
@router.get("/orders/{id}")
async def get_order(id: str, session = Depends(get_session)):
    repo = OrderRepository()
    return await repo.get_by_id(session, id)

# After (router)
@router.get("/orders/{id}")
async def get_order(id: str, session = Depends(get_session)):
    return await OrderService().get_by_id(session, id)

Fix Service Violations:

Move raw SQL to repositories:

# Create new repository method
class ReportRepository:
    async def get_summary(self, session):
        result = await session.execute(text("SELECT ..."))
        return result.fetchall()

Fix Repository Violations:

# Before
await session.commit()

# After
await session.flush()

CRITICAL REMINDER

This command MUST:

1. USE Glob to find files in each layer
2. USE Read to examine each file
3. USE Grep to search for violation patterns
4. ACTUALLY check for layer violations
5. OUTPUT a structured compliance report
6. OFFER to fix violations if found

DO NOT just tell the user to run a script. PERFORM THE CHECK.