From majestic-engineer
Resolves GitHub PR review comments by implementing fixes for bugs, refactors, style, tests, docs; verifies changes and generates resolution reports.
npx claudepluginhub majesticlabs-dev/majestic-marketplace --plugin majestic-engineerThis skill is limited to using the following tools:
**Audience:** Developers with PR review comments that need resolution.
Reads open GitHub PR review comments, triages by severity and type, applies code fixes, and drafts replies. Use for addressing PR feedback, fixing review issues, and responding to code reviews.
Fetches GitHub PR review comments via gh CLI, inventories by file/line/author, addresses each with code fixes, runs tests, commits referencing PR, pushes, and reports resolutions.
Fetches unresolved GitHub PR comments and threads, analyzes reviewer feedback, implements fixes, builds/tests, commits/pushes changes, replies to comments, and resolves threads.
Share bugs, ideas, or general feedback.
Audience: Developers with PR review comments that need resolution.
Goal: Understand reviewer feedback, implement changes, verify fixes.
# List all PR comments
gh pr view <PR_NUMBER> --comments
# Get review comments on files
gh api repos/{owner}/{repo}/pulls/{pr_number}/comments
# Get specific review details
gh api repos/{owner}/{repo}/pulls/{pr_number}/reviews
| Type | Indicators | Action |
|---|---|---|
| Bug fix | "This will break...", "Missing check..." | Implement the fix |
| Refactor | "Extract this...", "This is too complex..." | Apply the pattern |
| Style | "Rename to...", "Format as..." | Adjust naming/format |
| Tests | "Add test for...", "Missing coverage..." | Add test cases |
| Docs | "Add comment...", "Document this..." | Add documentation |
| Questions | "Why...?", "What about...?" | Reply with explanation |
PR Comment Resolution
Comment: "[Quote or summary of feedback]"
Location: `file:line`
Changes:
- `path/to/file`: [Change description]
- `path/to/test`: [Test updates if any]
Resolution:
[How changes address the feedback]
Verified:
- [Tests run, if applicable]
Notes:
[Any context for reviewer]
PR Comment Resolution
Comment: "This function is too complex, please extract validation"
Location: `app/services/order.py:45`
Changes:
- `app/services/order.py`: Extracted to `_validate_items()`
- `tests/test_order.py`: Added tests for new method
Resolution:
Split 25-line method into two focused functions with single responsibility.
Verified:
- `pytest tests/test_order.py` - all passing
PR Comment Resolution
Comment: "Add test for the edge case when list is empty"
Location: `src/utils/helpers.ts:23`
Changes:
- `tests/utils/helpers.test.ts`: Added empty array test case
Resolution:
Added test that verifies graceful handling of empty input.
Verified:
- `npm test -- helpers` - all passing
If comment is unclear or conflicting: