Code Review Skill

Automated code review with confidence-based filtering and test coverage assessment.

Invocation

/code-review:review                    # Standard review (Opus)
/code-review:review --quick            # Fast: lint + types + secrets only
/code-review:review --thorough         # Deep: parallel specialized reviewers
/code-review:review <issue-id>         # Review for specific issue

Core Capabilities

1. Confidence-Based Review

Reviews code with precision scoring to minimize false positives:

Score	Meaning	Action
0	False positive / pre-existing	Skip
25	Might be real, can't verify	Skip
50	Real but minor nitpick	Skip
75	Likely real but uncertain	Skip
80-94	Verified issue	Flag
95-100	Certain bug or rule violation	Auto-fix

2. Test Coverage Assessment

Every review includes a needs_tests assessment.

The reviewer evaluates whether changes warrant test coverage based on:

Factor	Indicators
Complexity	Cyclomatic complexity, lines changed, branching logic
Risk Areas	Auth, payments, data mutations, API changes
Missing Coverage	New functions/classes without corresponding tests
Regression Risk	Bug fixes that could recur, edge cases discovered

Test Assessment Output

{
  "needs_tests": true,
  "test_assessment": {
    "recommendation": "required",
    "rationale": "New API endpoint with input validation and error handling",
    "suggested_tests": [
      {
        "type": "unit",
        "target": "validateUserInput()",
        "cases": ["valid input", "empty input", "malformed input"]
      },
      {
        "type": "integration",
        "target": "POST /api/users",
        "cases": ["success path", "validation errors", "auth failure"]
      }
    ],
    "priority": "high",
    "auto_writable": false
  }
}

Test Recommendation Levels

Level	When	Action
required	New logic, complex branching, risk area	Block until tests added
recommended	Moderate changes, some complexity	Flag for consideration
optional	Simple changes, low risk	Note but don't block
skip	Docs, config, formatting, existing test coverage	No tests needed

3. Auto-Fix Protocol

For issues with >=95% confidence:

1. Make minimal changes - only fix the issue
2. Preserve existing formatting
3. Run linter after fix
4. Verify build still works

Safe to auto-fix: Unused imports, console.log statements, formatting, typos

Never auto-fix: Logic changes, security issues, test coverage gaps

---

Review Modes

Quick Mode (--quick)

Fast checks for trivial changes:

• Lint check
• Type check
• Secret scan
• Test assessment: skip (trivial changes)

Standard Mode (default)

Spawns code-review:reviewer agent (Opus):

• Reads CLAUDE.md files
• Reviews against project conventions
• Confidence-based filtering
• Full test assessment
• Auto-fixes high-confidence issues

Thorough Mode (--thorough)

Parallel specialized reviewers:

1. CLAUDE.md compliance scan
2. Bug detection
3. Silent failure hunt (via /code-review:silent-failures)
4. Security scan (via /code-review:security)
5. Test coverage analysis

---

Output Format

{
  "passed": true,
  "mode": "standard",
  "summary": "Reviewed 5 files. Auto-fixed 2 issues. No blockers.",
  "claude_md_checked": ["CLAUDE.md"],
  "auto_fixed": [
    {"file": "src/utils.ts", "line": 45, "issue": "Unused import", "confidence": 98}
  ],
  "flagged": [
    {"severity": "important", "file": "src/api.ts", "line": 23, "issue": "Missing error handling", "confidence": 85}
  ],
  "blockers": [],
  "needs_tests": true,
  "test_assessment": {
    "recommendation": "recommended",
    "rationale": "New utility function with multiple code paths",
    "suggested_tests": [
      {"type": "unit", "target": "formatDate()", "cases": ["valid date", "invalid date", "null input"]}
    ],
    "priority": "medium",
    "auto_writable": true
  }
}

---

Integration Points

Worker Done Pipeline

Code review integrates with completion pipelines:

1. Code review runs with test assessment
2. If needs_tests: true and recommendation: required:
   • Block until tests are added
   • Suggest specific test cases
3. If auto_writable: true:
   • Optionally generate tests automatically
4. Otherwise flag for manual review

Test Generation

When auto_writable: true, can spawn test-writer:

Task(
  subagent_type="general-purpose",
  prompt="Write tests for changes. Assessment: ${test_assessment}"
)

---

Test Assessment Criteria

Requires Tests (recommendation: required)

• New API endpoints
• Authentication/authorization changes
• Payment/billing logic
• Data mutation functions
• Functions with >3 branches
• Bug fixes without regression tests

Recommended Tests

• New utility functions
• Significant refactors
• Error handling changes
• State management changes

Optional/Skip

• Documentation changes
• Config file changes
• Formatting/style changes
• Changes to existing test files
• Pure type definitions

---

Related

Resource	Purpose
agents/reviewer.md	Agent implementation
skills/silent-failures/SKILL.md	Error handling audit
skills/security/SKILL.md	Security vulnerability scan
skills/review-practices/SKILL.md	Code review behavioral practices