smart-commit

Smart Commit Workflow

Perform a safe, streamlined commit workflow with test verification, domain safety checks, and optional PR creation.

Arguments

• No argument: commit and push to current branch
• pr: commit, push, and create a pull request via gh pr create

7-Step Workflow

Step 1: Identify Changed Files

Run git diff --name-only and git diff --cached --name-only to identify all modified, added, and deleted files. Also run git status to see untracked files. Build the full list of files to commit.

Step 2: Run Affected Tests -- STOP If Any Fail

For each changed source file under src/, find its co-located test file:

• src/app/lib/foo-actions.ts -> src/app/lib/foo-actions.test.ts
• src/lib/bar.ts -> src/lib/bar.test.ts
• src/app/api/baz/route.ts -> src/app/api/baz/route.test.ts

If the changed file IS a test file, run it directly.

Run all discovered test files:

node node_modules/vitest/vitest.mjs run <test-file-1> <test-file-2> ...

If any test fails, STOP immediately. Do not proceed to commit. Report which tests failed and why.

Step 3: Check Domain Safety

Flag a warning if any changed files match sensitive patterns:

Pattern	Warning
src/lib/money.ts	Financial math changes
src/lib/stripe.ts	Payment flow changes
src/auth.ts, src/auth.config.ts	Auth config changes
src/middleware.ts	Middleware changes
prisma/schema.prisma	Schema changes
**/expense-actions.ts	Financial action changes
**/financial-actions.ts	Financial action changes
src/lib/cron-guard.ts	Cron security changes
src/app/lib/guide-auth.ts	Guide portal auth changes
src/app/lib/driver-auth.ts	Driver portal auth changes

If sensitive files are detected, include a [SAFETY] note in the commit message body listing which sensitive areas were touched.

Step 4: Stage Specific Files by Name

Stage each changed file individually by name. NEVER use git add -A or git add . -- these can accidentally include sensitive files (.env, credentials) or large binaries.

git add src/app/lib/foo-actions.ts src/app/lib/foo-actions.test.ts

Step 5: Generate Conventional Commit Message

Analyze the staged diff to generate a commit message following conventional commit format:

• feat: -- new feature or capability
• fix: -- bug fix
• refactor: -- code restructuring without behavior change
• test: -- adding or updating tests only
• docs: -- documentation changes only
• chore: -- tooling, config, dependencies

Keep the subject line under 72 characters. Add a body with bullet points if the change is non-trivial. If domain-safety files were flagged in step 3, add a [SAFETY] section to the body.

Step 6: Commit and Push

Create the commit with the Co-Authored-By trailer:

git commit -m "$(cat <<'EOF'
feat: add expense category management

- Create/update/delete with org-scoped IDOR protection
- Zod v4 validation with audit logging
- Co-located tests with full mock coverage

[SAFETY] Touches: expense-actions.ts (financial actions)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
EOF
)"

Push to the current branch:

git push origin HEAD

Step 7: Create PR (if pr argument provided)

If the user passed the pr argument, create a pull request using gh:

1. Determine the base branch (typically main).
2. Create the PR with a structured body:

gh pr create --title "feat: add expense category management" --body "$(cat <<'EOF'
## Summary
- Added CRUD server actions for expense categories
- Full org-scoped IDOR protection
- Co-located Vitest test suite

## Safety
- Touches: `expense-actions.ts` (financial actions)

## Test plan
- [ ] Run `node node_modules/vitest/vitest.mjs run` -- all tests pass
- [ ] Verify org isolation in staging
- [ ] Check affected portals: main dashboard

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
EOF
)"

Return the PR URL when complete.

Safety Rules

1. Never commit if tests fail. Always run affected tests first and refuse to proceed on failure.
2. Never use git add -A or git add . -- stage files individually by name.
3. Always include Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> in every commit.
4. Never force push (git push --force). If the push fails due to diverged history, inform the user and stop.
5. Never commit files that contain secrets (.env, .env.local, credentials.json, *.pem, *.key). Warn the user if such files appear in the diff.
6. Flag domain-safety sensitive files visibly in the commit message so reviewers are alerted.