/address

Process all review comments from the current review session and address issues systematically.

Execute the following workflow:

Phase 1: Load Review Session

1. Validate session exists:

   if [ ! -f .diff-feedback/comments.txt ]; then
     echo "Error: No active review session. Run 'diff-feedback' to start a review."
     exit 1
   fi
   

2. Read comment file using Read tool on .diff-feedback/comments.txt

Phase 2: Parse and Prioritize Comments

1. Extract comments by file and line number

   • Parse comment file structure (## File: ..., Line X:, General:)
   • Group by file
   • Extract line numbers and comment descriptions
   • Skip header lines starting with #

2. Prioritize comments:

   • HIGH: Security issues, bugs, missing error handling, crashes
   • MEDIUM: Code quality, performance, refactoring, best practices
   • LOW: Style, documentation, suggestions, minor improvements

3. Create todo list with TodoWrite:

   • Format: [PRIORITY] Description - File:Line
   • Example: [HIGH] Fix useEffect dependency - ThemeToggle.tsx:42

4. Handle empty comments:

   • If no comments found (only headers and empty sections), output:

     No review comments found in .diff-feedback/comments.txt
     
     The comment file contains only template sections with no actual feedback.
     Either add comments to the file, or the review is complete.
     

   • Exit gracefully without error

Phase 3: Address Comments Systematically

For each comment in priority order (HIGH → MEDIUM → LOW):

1. Read relevant file using Read tool
2. Analyze issue in context of surrounding code
3. Implement fix using Edit or Write tools
4. Mark todo complete after each fix
5. Provide explanation:
   • What the issue was
   • What you changed
   • Why this fix is correct

IMPORTANT:

• Process comments in PRIORITY order
• FULLY address each comment before moving to next
• Mark todos complete ONLY when fully fixed
• If a comment is unclear, skip it and ask user for clarification
• Group related fixes together when beneficial

Phase 4: Summary

After all comments addressed:

1. Count total comments processed
2. Summarize changes made (group by file)
3. Suggest next steps:
   • Review changes: git diff
   • Format code: /format (if applicable)
   • Run tests: Suggest appropriate test commands if test files modified
   • Commit: Offer to help create commit with descriptive message

Output Format

Reading review comments from .diff-feedback/comments.txt...

Found X comments across Y files.

Creating todos:
- [HIGH] Fix useEffect dependency - ThemeToggle.tsx:42
- [HIGH] Add error handling for theme fetch - ThemeToggle.tsx:67
- [MEDIUM] Extract theme detection to utility - General
- [LOW] Add JSDoc to theme selectors - selectors.ts

───────────────────────────────────────────────────────────

Addressing comments in priority order:

[HIGH] Fix useEffect dependency in ThemeToggle.tsx:42
→ Issue: Missing 'theme' dependency in useEffect array causes stale closure
→ Fix: Adding 'theme' to dependency array
✓ Fixed. useEffect now correctly re-runs when theme changes.

[HIGH] Add error handling for theme fetch in ThemeToggle.tsx:67
→ Issue: Unhandled promise rejection if theme fetch fails
→ Fix: Adding try-catch with fallback to default theme
✓ Fixed. Added error boundary with user-friendly fallback.

[MEDIUM] Extract theme detection to utility - General
→ Creating src/utils/themeDetection.ts
→ Moving detection logic from ThemeToggle.tsx
→ Updating imports in 3 files
✓ Fixed. Theme detection now reusable across components.

[LOW] Add JSDoc to theme selectors in selectors.ts
→ Adding documentation for selectTheme, selectThemeMode
✓ Fixed. Added JSDoc with parameter and return type descriptions.

───────────────────────────────────────────────────────────

Summary:
✓ Addressed 4 comments across 4 files:
  - ThemeToggle.tsx: 2 fixes (useEffect, error handling)
  - themeDetection.ts: 1 new file (extracted utility)
  - selectors.ts: 1 fix (JSDoc documentation)

Files modified:
  - src/components/ThemeToggle.tsx
  - src/utils/themeDetection.ts (new)
  - src/store/theme/selectors.ts
  - src/components/App.tsx (updated import)

Next steps:
1. Review changes: git diff
2. Format: /format
3. Test: yarn test src/components/ThemeToggle.test.tsx (if tests exist)
4. Commit when ready (reply 'yes' if you want me to create a commit)

Important Notes

• Process comments in PRIORITY order (HIGH → MEDIUM → LOW)
• FULLY address each comment before moving to next
• Use TodoWrite to track progress throughout
• Mark todos complete ONLY when fully fixed
• If comment is unclear, skip and ask user for clarification
• Group related fixes when it makes sense
• Provide clear explanations of changes made
• Always suggest next steps (review, format, test, commit)

Edge Cases

1. Empty comment file: Exit gracefully with message
2. Unclear comment: Skip and list unclear comments at end
3. File not found: Note in output and skip
4. Large refactoring: Ask user if they want to proceed before making extensive changes
5. Breaking changes: Warn user and confirm before proceeding