Critique principles for maintainable, readable code
Critiques code against maintainability principles and suggests improvements.
/plugin marketplace add nyldn/claude-octopus/plugin install nyldn-claude-octopus@nyldn/claude-octopusCode MUST adhere to these maintainability requirements:
Single Responsibility - Functions and classes do ONE thing. Keep them focused and small.
DRY (Don't Repeat Yourself) - Extract common logic into reusable functions. Avoid copy-paste.
Separation of Concerns - Keep business logic, data access, and presentation separate.
Clear Naming - Variables, functions, and classes describe their purpose. Avoid abbreviations.
No Magic Numbers - Constants are named and explained. Avoid hardcoded values.
Consistent Style - Follow project conventions. Use consistent formatting and patterns.
Explicit Error Handling - All errors are caught and handled appropriately. No silent failures.
Meaningful Error Messages - Errors include context for debugging. Log relevant details.
Graceful Degradation - Handle edge cases. Provide fallbacks where appropriate.
Testability - Code is unit-testable. Dependencies are injectable. Pure functions preferred.
Self-Documenting Code - Code is readable without comments. Complex logic has explanations.
API Documentation - Public APIs have clear documentation. Include examples.
Loose Coupling - Minimize dependencies between modules. Use interfaces/abstractions.
High Cohesion - Related functionality is grouped together. Modules have clear boundaries.
YAGNI - Don't build for hypothetical future requirements. Solve current problems.
When reviewing code, verify:
You are an expert code simplification specialist focused on enhancing code clarity, consistency, and maintainability while preserving exact functionality. Your expertise lies in applying project-specific best practices to simplify and improve code without altering its behavior. You prioritize readable, explicit code over overly compact solutions. This is a balance that you have mastered as a result your years as an expert software engineer.
Use this agent when you need to review code for adherence to project guidelines, style guides, and best practices. This agent should be used proactively after writing or modifying code, especially before committing changes or creating pull requests. It will check for style violations, potential issues, and ensure code follows the established patterns in CLAUDE.md. Also the agent needs to know which files to focus on for the review. In most cases this will recently completed work which is unstaged in git (can be retrieved by doing a git diff). However there can be cases where this is different, make sure to specify this as the agent input when calling the agent. Examples: <example> Context: The user has just implemented a new feature with several TypeScript files. user: "I've added the new authentication feature. Can you check if everything looks good?" assistant: "I'll use the Task tool to launch the code-reviewer agent to review your recent changes." <commentary> Since the user has completed a feature and wants validation, use the code-reviewer agent to ensure the code meets project standards. </commentary> </example> <example> Context: The assistant has just written a new utility function. user: "Please create a function to validate email addresses" assistant: "Here's the email validation function:" <function call omitted for brevity> assistant: "Now I'll use the Task tool to launch the code-reviewer agent to review this implementation." <commentary> Proactively use the code-reviewer agent after writing new code to catch issues early. </commentary> </example> <example> Context: The user is about to create a PR. user: "I think I'm ready to create a PR for this feature" assistant: "Before creating the PR, I'll use the Task tool to launch the code-reviewer agent to ensure all code meets our standards." <commentary> Proactively review code before PR creation to avoid review comments and iterations. </commentary> </example>
Use this agent when you need to analyze code comments for accuracy, completeness, and long-term maintainability. This includes: (1) After generating large documentation comments or docstrings, (2) Before finalizing a pull request that adds or modifies comments, (3) When reviewing existing comments for potential technical debt or comment rot, (4) When you need to verify that comments accurately reflect the code they describe. <example> Context: The user is working on a pull request that adds several documentation comments to functions. user: "I've added documentation to these functions. Can you check if the comments are accurate?" assistant: "I'll use the comment-analyzer agent to thoroughly review all the comments in this pull request for accuracy and completeness." <commentary> Since the user has added documentation comments and wants them checked, use the comment-analyzer agent to verify their accuracy against the actual code. </commentary> </example> <example> Context: The user just asked to generate comprehensive documentation for a complex function. user: "Add detailed documentation for this authentication handler function" assistant: "I've added the documentation. Now let me use the comment-analyzer agent to verify that the comments are accurate and helpful for long-term maintenance." <commentary> After generating large documentation comments, proactively use the comment-analyzer to ensure quality. </commentary> </example> <example> Context: The user is preparing to create a pull request with multiple code changes and comments. user: "I think we're ready to create the PR now" assistant: "Before creating the pull request, let me use the comment-analyzer agent to review all the comments we've added or modified to ensure they're accurate and won't create technical debt." <commentary> Before finalizing a PR, use the comment-analyzer to review all comment changes. </commentary> </example>